Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin 1.8.20 & Dokka 1.8.10 #1902

Merged
merged 7 commits into from
Apr 6, 2023
Merged

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Mar 30, 2023

Description

https://github.com/JetBrains/kotlin/releases/tag/v1.8.20
https://github.com/Kotlin/dokka/releases/tag/v1.8.10

Checklist

  • PR description added
  • tests are added
  • KtLint has been applied on source code itself and violations are fixed
  • documentation is updated
  • CHANGELOG.md is updated

In case of adding a new rule:

@paul-dingemans
Copy link
Collaborator

The reference to the Kotlin release (1.8.20) does not or no longer exist. I found 1.8.20-RC2 (https://github.com/JetBrains/kotlin/releases/tag/v1.8.20-RC2) as latest version. Should I still proceed with merge?

@Goooler
Copy link
Contributor Author

Goooler commented Mar 30, 2023

It was published to MavenCentral hours ago, but hasn't been released on GitHub, we can just wait a moment.

@paul-dingemans
Copy link
Collaborator

It was published to MavenCentral hours ago, but hasn't been released on GitHub, we can just wait a moment.

That at least explains why the build succeeded. I was confused about a build succeeding with an unreleased version ;-)

@Goooler
Copy link
Contributor Author

Goooler commented Mar 30, 2023

They always delay the releases on GitHub 🤣

@Goooler
Copy link
Contributor Author

Goooler commented Apr 3, 2023

It's out.

@paul-dingemans
Copy link
Collaborator

It's out.

Build broke on cache not having enough space. I have restarted the failed jobs. We have to monitor whether this happens more often.

@paul-dingemans paul-dingemans merged commit 272efed into pinterest:master Apr 6, 2023
@Goooler Goooler deleted the kt1820 branch April 6, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants