Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup toolchains, compile project with Java 20 only, run test on various Java versions #2120

Merged
merged 24 commits into from
Jul 31, 2023
Merged

Setup toolchains, compile project with Java 20 only, run test on various Java versions #2120

merged 24 commits into from
Jul 31, 2023

Commits on Jul 28, 2023

  1. Replace testing on java 19 with testing on java 20 

    Closes pinterest#1888
    @paul-dingemans @mateuszkwiecinski
    paul-dingemans authored and mateuszkwiecinski committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    88bde93 View commit details
    Browse the repository at this point in the history

  2. Fix toolchains. Compile project with Java 20, continue targeting Java… 

    … 1.8
    @mateuszkwiecinski
    mateuszkwiecinski committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    c1a0e41 View commit details
    Browse the repository at this point in the history

  3. Unify yml files formating

    @mateuszkwiecinski
    mateuszkwiecinski committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    7370ea0 View commit details
    Browse the repository at this point in the history

  4. Fix compiler warning

    @mateuszkwiecinski
    mateuszkwiecinski committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    b03a4be View commit details
    Browse the repository at this point in the history

  5. Do NOT compile the project with various Java version, instead test ag… 

    …ains various java verstions

https://jakewharton.com/build-on-latest-java-test-through-lowest-java/
    @mateuszkwiecinski
    mateuszkwiecinski committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    dbff741 View commit details
    Browse the repository at this point in the history

  6. Add -add-opens jvmArg to prevent ignored warnings

    @mateuszkwiecinski
    mateuszkwiecinski committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    652aef7 View commit details
    Browse the repository at this point in the history

  7. Fix readme badge

    @mateuszkwiecinski
    mateuszkwiecinski committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    9bf8592 View commit details
    Browse the repository at this point in the history

  8. Migrate away deprecated java.net.URL constructor

    @mateuszkwiecinski
    mateuszkwiecinski committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    b4f6146 View commit details
    Browse the repository at this point in the history

  9. Setup toolchain resolver 

    If someone doesn't have required java installed Gradle will attempt to install one
    @mateuszkwiecinski
    mateuszkwiecinski committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    bad36e7 View commit details
    Browse the repository at this point in the history

  10. Improve CI performance

    @mateuszkwiecinski
    mateuszkwiecinski committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    cf3464b View commit details
    Browse the repository at this point in the history

  11. Update workflow name

    @mateuszkwiecinski
    mateuszkwiecinski committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    9313464 View commit details
    Browse the repository at this point in the history

  12. Move JDK compile/target version to libs.versions.toml file

    @mateuszkwiecinski
    mateuszkwiecinski committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    12cdbf1 View commit details
    Browse the repository at this point in the history

  13. Add more explanation comments

    @mateuszkwiecinski
    mateuszkwiecinski committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    711e6bf View commit details
    Browse the repository at this point in the history

  14. Rename targetJavaVersion -> buildLogicTargetJavaVersion

    @mateuszkwiecinski
    mateuszkwiecinski committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    b9d6b7a View commit details
    Browse the repository at this point in the history

  15. Pre-register all testOnJdk test tasks for all LTS java versions

    @mateuszkwiecinski
    mateuszkwiecinski committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    9de34cc View commit details
    Browse the repository at this point in the history

  16. Extract common build setup + fix memory settings 

    The build needs less than 0.5GB of a java heap memory. There is no value in reserving more than half of available RAM just for the Gradle demon. It's better to keep Gradle daemon small  and leave the memory available to other forked processes (i.e. tests)
    @mateuszkwiecinski
    mateuszkwiecinski committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    b1823b4 View commit details
    Browse the repository at this point in the history

  17. Disable VFS on CI 

    CI doesn't modify files, there is no value in putting extra effort in efficiently tracking changed files. From test runs VFS comes with noticable performance impact on Windows build
    @mateuszkwiecinski
    mateuszkwiecinski committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    1931e09 View commit details
    Browse the repository at this point in the history

  18. Update comment with extra clarification

    @mateuszkwiecinski
    mateuszkwiecinski committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    18f069f View commit details
    Browse the repository at this point in the history

  19. Disable automatic build scans publishing on local builds

    @mateuszkwiecinski
    mateuszkwiecinski committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    455b383 View commit details
    Browse the repository at this point in the history

  20. Update kotlin dev version

    @mateuszkwiecinski
    mateuszkwiecinski committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    0ab55cc View commit details
    Browse the repository at this point in the history

  21. Fix -PkotlinDev not running tests agains configured kotlin version

    @mateuszkwiecinski
    mateuszkwiecinski committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    a49c0d5 View commit details
    Browse the repository at this point in the history

  22. Fix -PkotlinDev artifacts version

    @mateuszkwiecinski
    mateuszkwiecinski committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    3a0abff View commit details
    Browse the repository at this point in the history

  23. Run -PkotlinDev build as a separate workflow job in parallel

    @mateuszkwiecinski
    mateuszkwiecinski committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    3ab1521 View commit details
    Browse the repository at this point in the history

  24. Add extra comment explaining CI runner settings

    @mateuszkwiecinski
    mateuszkwiecinski committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    53bd98f View commit details
    Browse the repository at this point in the history