Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote experimental rules #2218

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Conversation

paul-dingemans
Copy link
Collaborator

Description

Promote rules below to non-experimental rules:

  • blank-line-before-declaration
  • context-receiver-wrapping
  • discouraged-comment-location
  • enum-wrapping
  • function-naming
  • function-signature
  • if-else-bracing
  • multiline-expression-wrapping
  • if-else-wrapping
  • no-blank-line-in-list
  • no-consecutive-comments
  • no-empty-file
  • no-empty-first-line-in-class-body
  • no-single-line-block-comment
  • parameter-list-spacing
  • property-naming
  • statement-wrapping
  • string-template-indent
  • try-catch-finally-spacing
  • type-argument-list-spacing
  • type-parameter-list-spacing
  • unnecessary-parentheses-before-trailing-lambda

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • CHANGELOG.md is updated
  • PR description added

Documentation is updated. See difference between snapshot and release documentation

* Add annotation `SinceKtlint` to document in which ktlint version a rule was added as experimental and/or stable
* Fix and simplify baseline tests as test were failing due to experimental rules being promoted to non-experimental
…mental to public API for binary compatibility validator
@paul-dingemans paul-dingemans merged commit 03b7584 into master Aug 29, 2023
22 checks passed
@paul-dingemans paul-dingemans deleted the promote-experimental-rules branch August 29, 2023 15:01
@paul-dingemans paul-dingemans added this to the 1.0 (Yeah!) milestone Sep 5, 2023
3flex added a commit to detekt/detekt that referenced this pull request Sep 6, 2023
These were promoted to running by default in pinterest/ktlint#2218
3flex added a commit to detekt/detekt that referenced this pull request Sep 6, 2023
These were promoted to running by default in pinterest/ktlint#2218
3flex added a commit to detekt/detekt that referenced this pull request Sep 17, 2023
These were promoted to running by default in pinterest/ktlint#2218
3flex added a commit to detekt/detekt that referenced this pull request Oct 5, 2023
These were promoted to running by default in pinterest/ktlint#2218
3flex added a commit to detekt/detekt that referenced this pull request Oct 8, 2023
These were promoted to running by default in pinterest/ktlint#2218
3flex added a commit to detekt/detekt that referenced this pull request Oct 13, 2023
These were promoted to running by default in pinterest/ktlint#2218
3flex added a commit to detekt/detekt that referenced this pull request Oct 13, 2023
These were promoted to running by default in pinterest/ktlint#2218
3flex added a commit to detekt/detekt that referenced this pull request Nov 1, 2023
These were promoted to running by default in pinterest/ktlint#2218
3flex added a commit to detekt/detekt that referenced this pull request Nov 1, 2023
…6468)

* Update dependency com.pinterest.ktlint:ktlint-ruleset-standard to v1

* Update dependency com.pinterest.ktlint:ktlint-ruleset-standard to v1.0.1

* Update imports for renamed ktlint classes

See pinterest/ktlint#2178

* Add new ktlint rules added in v1.0

* ChainMethodContinuation
* ClassSignature
* FunctionExpressionBody
* FunctionLiteral
* FunctionTypeModifierSpacing

* Fix packaging

kotlin-logging group changed from io.github.microutils to
io.github.oshai. From v5 it does not depend on slf4j-api. ktlint-logger
doesn't depend on slf4j-api either so we need to include it as a runtime
dependency now.

* Enable formerly experimental rules by default

These were promoted to running by default in pinterest/ktlint#2218

* Remove redundant declarations from detekt's detekt config

* Disable formatting rules that have many violations

* Fix remaining ktlint issues

* Fix ktlint doc link in NoEmptyFirstLineInClassBody

Co-authored-by: marschwar <marschwar@users.noreply.github.com>

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Matthew Haughton <3flex@users.noreply.github.com>
Co-authored-by: marschwar <marschwar@users.noreply.github.com>
mgroth0 pushed a commit to mgroth0/detekt that referenced this pull request Feb 11, 2024
…etekt#6468)

* Update dependency com.pinterest.ktlint:ktlint-ruleset-standard to v1

* Update dependency com.pinterest.ktlint:ktlint-ruleset-standard to v1.0.1

* Update imports for renamed ktlint classes

See pinterest/ktlint#2178

* Add new ktlint rules added in v1.0

* ChainMethodContinuation
* ClassSignature
* FunctionExpressionBody
* FunctionLiteral
* FunctionTypeModifierSpacing

* Fix packaging

kotlin-logging group changed from io.github.microutils to
io.github.oshai. From v5 it does not depend on slf4j-api. ktlint-logger
doesn't depend on slf4j-api either so we need to include it as a runtime
dependency now.

* Enable formerly experimental rules by default

These were promoted to running by default in pinterest/ktlint#2218

* Remove redundant declarations from detekt's detekt config

* Disable formatting rules that have many violations

* Fix remaining ktlint issues

* Fix ktlint doc link in NoEmptyFirstLineInClassBody

Co-authored-by: marschwar <marschwar@users.noreply.github.com>

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Matthew Haughton <3flex@users.noreply.github.com>
Co-authored-by: marschwar <marschwar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant