Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support logging and exception throwing when loading baseline #2362

Merged
merged 3 commits into from
Nov 19, 2023

Conversation

paul-dingemans
Copy link
Collaborator

Description

Support logging and exception throwing when loading baseline

The caller should be able to determine how errors while loading the baseline are to be handled. The ktlint CLI expects errors to be printed to the log. The ktlint-intellij-plugin requires exceptions to be thrown as the log is invisible for the plugin.

Closes #2344

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • CHANGELOG.md is updated
  • PR description added

Documentation is updated. See difference between snapshot and release documentation

The caller should be able to determine how errors while loading the baseline are to be handled. The ktlint CLI expects errors to be printed to the log. The ktlint-intellij-plugin requires exceptions to be thrown as the log is invisible for the plugin.

Closes #2344
@paul-dingemans paul-dingemans added this to the 1.1 milestone Nov 18, 2023
@paul-dingemans paul-dingemans merged commit 7c56501 into master Nov 19, 2023
22 checks passed
@paul-dingemans paul-dingemans deleted the 2344-loadbaseline-exception branch November 19, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throw exception in Baseline load instead of printing log message
1 participant