Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty constructor for expected class declaration #2431

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

paul-dingemans
Copy link
Collaborator

Description

Allow empty constructor for expected class declaration (https://kotlinlang.org/docs/multiplatform-expect-actual.html#rules-for-expected-and-actual-declarations).

Closes #2425

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

@paul-dingemans paul-dingemans added this to the 1.1 milestone Dec 11, 2023
Copy link
Contributor

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for fixing it!

@paul-dingemans paul-dingemans merged commit 2d480c6 into master Dec 11, 2023
22 checks passed
@paul-dingemans paul-dingemans deleted the 2425-class-signature branch December 11, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow empty constructur call in expected class declaration
2 participants