Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix insert of suppression on binary expression #2463

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Fix insert of suppression on binary expression #2463

merged 1 commit into from
Dec 26, 2023

Commits on Dec 23, 2023

  1. Do not place an annotation on a value argument, value parameter, type… 

    … parameter, or type projection in case it is a binary expression

Make creation of the annotation more safe by not using a fake top element in the code which is used to generate the AST.

The 'Suppress' annotation has a parameter, which by default is not allowed to be placed inline (it should start on a new line). Just putting it above the binary expression results in it being applied to the first subexpression only instead of on the entire binary expression.

Closes #2462
    @paul-dingemans
    paul-dingemans committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    138dcbd View commit details
    Browse the repository at this point in the history