Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep arrow when both parameter list and block of function literal are empty #2469

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

paul-dingemans
Copy link
Collaborator

Description

Keep arrow when both parameter list and block of function literal are empty

Removal of the arrow in this case would lead to a compilation error as the function literal is changed to a normal block when removing the arrow.

Closes #2465

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

… empty

Removal of the arrow in this case would lead to a compilation error as the function literal is changed to a normal block when removing the arrow.

Closes #2465
@paul-dingemans paul-dingemans added this to the 1.1.1 milestone Dec 27, 2023
@paul-dingemans paul-dingemans merged commit 55060c3 into master Dec 29, 2023
12 checks passed
@paul-dingemans paul-dingemans deleted the 2465-function-literal branch December 29, 2023 19:03
paul-dingemans added a commit to Goooler/ktlint that referenced this pull request Jan 2, 2024
… empty (pinterest#2469)

Removal of the arrow in this case would lead to a compilation error as the function literal is changed to a normal block when removing the arrow.

Closes pinterest#2465
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[standard:function-literal] Lambda arrow is removed too aggressively, produces non-compiling code
1 participant