Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not indent string template starting at first position of line #2553

Merged
merged 3 commits into from
Feb 14, 2024

Conversation

paul-dingemans
Copy link
Collaborator

@paul-dingemans paul-dingemans commented Feb 13, 2024

Description

Do not indent string template starting at first position of line

Also, the indent rule should not change unexpected indentation characters inside a string template but leave this up to the string-template-indent rule. As a result the indent rule could be a bit simplified.

Closes #2530

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

Also, the `indent` rule should not change unexpected indentation characters inside a string template but leave this up to the `string-template-indent` rule. As a result the `indent` rule could be a bit simplified.
Also, the `indent` rule should not change unexpected indentation characters inside a string template but leave this up to the `string-template-indent` rule. As a result the `indent` rule could be a bit simplified.

Closes #2350
Also, the `indent` rule should not change unexpected indentation characters inside a string template but leave this up to the `string-template-indent` rule. As a result the `indent` rule could be a bit simplified.

Closes #2350
@paul-dingemans paul-dingemans added this to the 1.2 milestone Feb 13, 2024
@paul-dingemans paul-dingemans merged commit 8eb0a58 into master Feb 14, 2024
12 checks passed
@paul-dingemans paul-dingemans deleted the 2530-string-template branch February 14, 2024 16:49
@paul-dingemans
Copy link
Collaborator Author

Closes #2530

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

string-template-indent changes content of string literal
1 participant