-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress remove curly braces from template #157 #263
Merged
Tapchicoma
merged 12 commits into
pinterest:master
from
AleksandrSl:feature/suppress-remove-curly-braces-from-template
Nov 11, 2019
Merged
Suppress remove curly braces from template #157 #263
Tapchicoma
merged 12 commits into
pinterest:master
from
AleksandrSl:feature/suppress-remove-curly-braces-from-template
Nov 11, 2019
Commits on Nov 7, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 5ec6dbd - Browse repository at this point
Copy the full SHA 5ec6dbdView commit details -
Try top down approach. I need line numbers for suppression, it's not so trivial. Why not use offset for suppression?
Configuration menu - View commit details
-
Copy full SHA for 035685f - Browse repository at this point
Copy the full SHA 035685fView commit details -
Current flow is that all string-template errors are suppressed by RemoveCurlyBracesFromTemplate.
Configuration menu - View commit details
-
Copy full SHA for ef90195 - Browse repository at this point
Copy the full SHA ef90195View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca32657 - Browse repository at this point
Copy the full SHA ca32657View commit details -
It turned out that @Suppress with arrayOf and [] are compile errors, and can be used only with destructuring.
Configuration menu - View commit details
-
Copy full SHA for bb39bde - Browse repository at this point
Copy the full SHA bb39bdeView commit details -
Add more test for different annotations use sites.
Configuration menu - View commit details
-
Copy full SHA for fca3b6c - Browse repository at this point
Copy the full SHA fca3b6cView commit details -
Shame on me, forgot to remove "debugging" code
Configuration menu - View commit details
-
Copy full SHA for b7733b5 - Browse repository at this point
Copy the full SHA b7733b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for a2a4ab1 - Browse repository at this point
Copy the full SHA a2a4ab1View commit details -
Cleanup suppress annotations related code
Distinct is redundant, cause toSet is called on the list afterwards.
Configuration menu - View commit details
-
Copy full SHA for 0f000f9 - Browse repository at this point
Copy the full SHA 0f000f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe8e310 - Browse repository at this point
Copy the full SHA fe8e310View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ee8253 - Browse repository at this point
Copy the full SHA 4ee8253View commit details -
Improve code readability by extracting function for suppress annotati…
…ons processing
Alexander Slepchenkov committedNov 7, 2019 Configuration menu - View commit details
-
Copy full SHA for a0f3a4b - Browse repository at this point
Copy the full SHA a0f3a4bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.