Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress remove curly braces from template #157 #263

Merged
merged 12 commits into from
Nov 11, 2019
Merged

Suppress remove curly braces from template #157 #263

merged 12 commits into from
Nov 11, 2019

Commits on Nov 7, 2019

  1. WIP

    @AleksandrSl
    AleksandrSl authored and aslepchenkov committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    5ec6dbd View commit details
    Browse the repository at this point in the history

  2. WIP 

    Try top down approach. I need line numbers for suppression, it's not
so trivial. Why not use offset for suppression?
    @AleksandrSl
    AleksandrSl authored and aslepchenkov committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    035685f View commit details
    Browse the repository at this point in the history

  3. Implement top-down scenario 

    Current flow is that all string-template errors are suppressed by
RemoveCurlyBracesFromTemplate.
    @AleksandrSl
    AleksandrSl authored and aslepchenkov committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    ef90195 View commit details
    Browse the repository at this point in the history

  4. Fix cherry-pick consequences

    @AleksandrSl
    AleksandrSl authored and aslepchenkov committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    ca32657 View commit details
    Browse the repository at this point in the history

  5. Simplify code 

    It turned out that @Suppress with arrayOf and [] are
compile errors, and can be used only with destructuring.
    @AleksandrSl
    AleksandrSl authored and aslepchenkov committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    bb39bde View commit details
    Browse the repository at this point in the history

  6. Regard SuppressWarnings also 

    Add more test for different annotations use sites.
    @AleksandrSl
    AleksandrSl authored and aslepchenkov committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    fca3b6c View commit details
    Browse the repository at this point in the history

  7. Clean tests 

    Shame on me, forgot to remove "debugging" code
    @AleksandrSl
    AleksandrSl authored and aslepchenkov committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    b7733b5 View commit details
    Browse the repository at this point in the history

  8. Remove unused import from KtLint.kt

    @AleksandrSl
    AleksandrSl authored and aslepchenkov committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    a2a4ab1 View commit details
    Browse the repository at this point in the history

  9. Cleanup suppress annotations related code 

    Distinct is redundant, cause toSet is called on the list
afterwards.
    @AleksandrSl
    AleksandrSl authored and aslepchenkov committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    0f000f9 View commit details
    Browse the repository at this point in the history

  10. Clarify test meaning for suppress annotations

    @AleksandrSl
    AleksandrSl authored and aslepchenkov committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    fe8e310 View commit details
    Browse the repository at this point in the history

  11. Fix typo in comments

    @AleksandrSl
    AleksandrSl authored and aslepchenkov committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    4ee8253 View commit details
    Browse the repository at this point in the history

  12. Improve code readability by extracting function for suppress annotati… 

    …ons processing
    Alexander Slepchenkov committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    a0f3a4b View commit details
    Browse the repository at this point in the history