-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix blank line before declarations
rule code example
#2657
Conversation
blank line before declarations
rule code example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tnx for fixing. I will make a slight alteration before merge.
@@ -59,22 +59,22 @@ Requires a blank line before any class or function declaration. No blank line is | |||
=== "[:material-heart:](#) Ktlint" | |||
|
|||
```kotlin | |||
const val FOO_1 = "foo1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FOO_1
is used intentionally. Constant value which are deeply immutable property should be written in screaming case according to property-naming
rule. Of course it should have been consistent with the disallowed example.
@@ -59,22 +59,22 @@ Requires a blank line before any class or function declaration. No blank line is | |||
=== "[:material-heart:](#) Ktlint" | |||
|
|||
```kotlin | |||
const val FOO_1 = "foo1" | |||
const val foo1 = "foo1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FOO_1
is used intentionally. Constant value which are deeply immutable property should be written in screaming case according to property-naming
rule. Of course it should have been consistent with the disallowed example.
I learned a lot! Thank you :) |
Description
The code example used to demonstrate disallowed code was correctly formatted (i.e., there were blank lines before declarations). This change corrects the example to properly reflect code that violates the rule.
Checklist
Before submitting the PR, please check following (checks which are not relevant may be ignored):
Closes #<xxx>
orFixes #<xxx>
(replace<xxx>
with issue number)Documentation is updated. See difference between snapshot and release documentation