Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix suppression handling when 'formatter:on' not properly specified #2719

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

paul-dingemans
Copy link
Collaborator

Description

Fix suppression handling when 'formatter:on' not properly specified

If the 'formatter:on' tag is not specified in the same scope as the 'formatter:off' tag, then the IndentationRule might throw an exception as the IndentationContextStack is not properly cleaned.

Also, cleaned up of CommentSuppressionHint.EOL type as it was not used since replacing the EOL suppression hints in 1.0 release.

Closes #2695

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

If the 'formatter:on' tag is not specified in the same scope as the 'formatter:off' tag, then the IndentationRule might throw an exception as the IndentationContextStack is not properly cleaned.

 Also, cleaned up of `CommentSuppressionHint.EOL` type as it was not used since replacing the EOL suppression hints in `1.0` release.

Closes #2695
@paul-dingemans paul-dingemans added this to the 1.3.1 milestone Jun 25, 2024
@paul-dingemans paul-dingemans merged commit 5fb8373 into master Jun 25, 2024
12 checks passed
@paul-dingemans paul-dingemans deleted the 2695-suppression-locator branch June 25, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indentation error on malformed formatter closing tag
1 participant