Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore suppressions for no-unused-imports rule #2720

Merged
merged 2 commits into from
Jun 29, 2024

Conversation

paul-dingemans
Copy link
Collaborator

Description

Ignore suppressions for no-unused-imports rule

Imports which are only used in code blocks which are suppressed for ktlint should not be reported as unused as removal results in compilation errors.

Refactored the code so that a rule can be marked with interface IgnoreKtlintSuppressions to indicate that all suppressions for this rule are to be ignored.

Closes #2696

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

Imports which are only used in code blocks which are suppressed for ktlint should not be reported as unused as removal results in compilation errors.

Refactored the code so that a rule can be marked with interface `IgnoreKtlintSuppressions` to indicate that all suppression for this rule are to be ignored.

Closes #2696
@paul-dingemans paul-dingemans added this to the 1.3.1 milestone Jun 26, 2024
@paul-dingemans paul-dingemans merged commit abb24b9 into master Jun 29, 2024
22 checks passed
@paul-dingemans paul-dingemans deleted the 2696-no-unused-imports branch June 29, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imports only used in blocks which may not be formatted are reported as unused
1 participant