Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false alert Format was not able to resolve all violations which (theoretically) can be autocorrected #2727

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Fix false alert Format was not able to resolve all violations which (theoretically) can be autocorrected #2727

merged 3 commits into from
Jul 2, 2024

Conversation

paul-dingemans
Copy link
Collaborator

Description

The warning "Format was not able to resolve all violations" should not be logged in case the code only contains lint violations which may not be autocorrected according to the AutoCorrectHandler.

Closes #2726

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

@paul-dingemans
Do not log warning "Format was not able to resolve all violations"
de81b64 
The warning "Format was not able to resolve all violations" should not be logged in case the code only contains lint violations which may not be autocorrected according to the AutoCorrectHandler.

Closes #2726
@paul-dingemans
Do not log warning "Format was not able to resolve all violations"
bf62749 
The warning "Format was not able to resolve all violations" should not be logged in case the code only contains lint violations which may not be autocorrected according to the AutoCorrectHandler.

Closes #2726
@paul-dingemans
Merge remote-tracking branch 'origin/2726-false-alert-fail-format' in…
0c891c0 
…to 2726-false-alert-fail-format

# Conflicts:
#	ktlint-rule-engine/src/main/kotlin/com/pinterest/ktlint/rule/engine/internal/CodeFormatter.kt
@paul-dingemans paul-dingemans added this to the 1.3.1 milestone Jul 2, 2024
@paul-dingemans paul-dingemans merged commit 15fb36d into master Jul 2, 2024
12 checks passed
@paul-dingemans paul-dingemans deleted the 2726-false-alert-fail-format branch July 2, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix changelog
Projects
None yet
Milestone
1.3.1
Development

Successfully merging this pull request may close these issues.

Format was not able to resolve all violations which (theoretically) can be autocorrected
1 participant
@paul-dingemans