Make spec file parsing working on Windows #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rom4ek I don't actually have a Windows machine to run this on, but I'm fine with merging it once you resolve the conflicts assuming the tests continue to pass. |
romtsn
force-pushed
the
platform-agnostic-spec-parsing
branch
from
7406443
to
ab30e46
Compare
|
@shashachu Done. I guess nobody has a Windows machine besides me :D |
|
@shashachu Suggestion: consider adding a Microsoft Azure test plan configuration to tests code with on Windows. https://azure.microsoft.com/en-us/services/devops/pipelines/ |
|
@JLLeitschuh good idea. I'll open up an issue for it. |
|
Filed here #406 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing
mvn clean verifyon Windows actually does not work - due to\r\nusage in spec files, it fails to parse them. So I just replace it with\n.