Account for super keyword in SpacingAroundParensRule #373
Conversation
* When checking for unexpected spaces preceding a `(`, the rule was only checking elementType `IDENTIFIER`, so added a check for `SUPER_KEYWORD` * Updated lint and formatting tests
shashachu
changed the title
|
Fixes #369 |
| @@ -23,7 +29,11 @@ class SpacingAroundParensRule : Rule("paren-spacing") { | |||
| val nextLeaf = node.nextLeaf() | |||
| val spacingBefore = if (node.elementType == LPAR) { | |||
| prevLeaf is PsiWhiteSpace && !prevLeaf.textContains('\n') && | |||
| prevLeaf.prevLeaf()?.elementType == IDENTIFIER && ( | |||
| ( | |||
There was a problem hiding this comment.
This formatting looks pretty wacky to me, but AS seems to agree it's correct.
There was a problem hiding this comment.
It's weird the this open paren is on a new line but the open paren on line 36 is not.
There was a problem hiding this comment.
Yeah I agree. There's definitely bugs with the indent formatting rule but I can't always figure them out.
| /** | ||
| * Ensures there are no extra spaces around parentheses. | ||
| * | ||
| * See https://kotlinlang.org/docs/reference/coding-conventions.html, "Horizontal Whitespace" |
There was a problem hiding this comment.
if you want, you can use the fragment: https://kotlinlang.org/docs/reference/coding-conventions.html#horizontal-whitespace
There was a problem hiding this comment.
ah yes I was looking for that and just looked through it. will update.
| @@ -23,7 +29,11 @@ class SpacingAroundParensRule : Rule("paren-spacing") { | |||
| val nextLeaf = node.nextLeaf() | |||
| val spacingBefore = if (node.elementType == LPAR) { | |||
| prevLeaf is PsiWhiteSpace && !prevLeaf.textContains('\n') && | |||
| prevLeaf.prevLeaf()?.elementType == IDENTIFIER && ( | |||
| ( | |||
There was a problem hiding this comment.
It's weird the this open paren is on a new line but the open paren on line 36 is not.
Tests were added to the lint and format spec files. |
(, the rule was only checking elementTypeIDENTIFIER, so added a check forSUPER_KEYWORD