Fixing issue where ktlint would erroneously want to insert a newline if parameter comments were used #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if parameter comments were used Fixes pinterest#433
shashachu
commented
May 22, 2019
| // Skip comments, whitespace, and empty nodes | ||
| !it.isPartOfComment() && | ||
| // Skip comments, whitespace, and empty nodes | ||
| !it.isPartOfComment() && | ||
| !it.isWhiteSpaceWithoutNewline() && |
There was a problem hiding this comment.
This formatting looks weird to me, but IntelliJ does the same thing.
There was a problem hiding this comment.
looks right; it's a continuation indent.
NightlyNexus
approved these changes
May 22, 2019
| // Skip comments, whitespace, and empty nodes | ||
| !it.isPartOfComment() && | ||
| // Skip comments, whitespace, and empty nodes | ||
| !it.isPartOfComment() && | ||
| !it.isWhiteSpaceWithoutNewline() && |
There was a problem hiding this comment.
looks right; it's a continuation indent.
shashachu
commented
May 22, 2019
Test.kt
Outdated
| @@ -0,0 +1,11 @@ | |||
| fun main() { | |||
There was a problem hiding this comment.
doh i did not mean to check this in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #433