Don't autoformat imports if the import list contains top-level comments #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,10 +25,17 @@ class ImportOrderingRule : Rule("import-ordering") { | |||
| val children = node.getChildren(null) | |||
| if (children.isNotEmpty()) { | |||
| val imports = children.filter { it.elementType == IMPORT_DIRECTIVE } | |||
| val hasComments = children.find { it.elementType == BLOCK_COMMENT || it.elementType == EOL_COMMENT } != null | |||
There was a problem hiding this comment.
a broad brush. should we check for the suppression message? though perhaps unlikely to be a problem in practice.
There was a problem hiding this comment.
The suppression message causes a real problem, but it would also seem annoying if you had comments (for some reason?) in an import list that they'd get blown away by the autoformatter.
NightlyNexus
approved these changes
May 30, 2019
| @@ -23,10 +25,17 @@ class ImportOrderingRule : Rule("import-ordering") { | |||
| val children = node.getChildren(null) | |||
| if (children.isNotEmpty()) { | |||
| val imports = children.filter { it.elementType == IMPORT_DIRECTIVE } | |||
| val hasComments = children.find { it.elementType == BLOCK_COMMENT || it.elementType == EOL_COMMENT } != null | |||
sowmyav24
pushed a commit
to sowmyav24/ktlint
that referenced
this pull request
Jun 9, 2019
sowmyav24
pushed a commit
to sowmyav24/ktlint
that referenced
this pull request
Jun 9, 2019
sowmyav24
pushed a commit
to sowmyav24/ktlint
that referenced
this pull request
Jun 9, 2019
sowmyav24
pushed a commit
to sowmyav24/ktlint
that referenced
this pull request
Jun 10, 2019
sowmyav24
pushed a commit
to sowmyav24/ktlint
that referenced
this pull request
Jun 10, 2019
sowmyav24
pushed a commit
to sowmyav24/ktlint
that referenced
this pull request
Jun 10, 2019
sowmyav24
pushed a commit
to sowmyav24/ktlint
that referenced
this pull request
Jun 10, 2019
sowmyav24
pushed a commit
to sowmyav24/ktlint
that referenced
this pull request
Jun 10, 2019
sowmyav24
pushed a commit
to sowmyav24/ktlint
that referenced
this pull request
Jun 10, 2019
sowmyav24
pushed a commit
to sowmyav24/ktlint
that referenced
this pull request
Jun 10, 2019
sowmyav24
pushed a commit
to sowmyav24/ktlint
that referenced
this pull request
Jun 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #408
Refusing to auto-import seemed much easier than trying to figure out which imports the comments were attached to.