Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "installGitPreCommitHook" sub command. #487

Merged

Conversation

Tapchicoma
Copy link
Collaborator

Move old one --install-git-pre-commit-hook option to be a ktlint
subcommand - new syntax: ktlint installGitPreCommitHook. Old option
--install-git-pre-commit-hook is still working, but deprecated.

This sub command acts as a separate action, that is not running checks, and should not confuse users oppose to option.

@Tapchicoma Tapchicoma force-pushed the git-pre-commit-hook-subcommand branch 3 times, most recently from 6ca7a4d to 2248540 Compare June 17, 2019 16:40
Move old one (`--install-git-pre-commit-hook`) option to be a ktlint
subcommand - new syntax: `ktlint installGitPreCommitHook`. Old one
`--install-git-pre-commit-hook` is still working, but deprecated.

Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>
@shashachu
Copy link
Contributor

👍

@shashachu shashachu merged commit 925146a into pinterest:master Jun 17, 2019
@Tapchicoma Tapchicoma deleted the git-pre-commit-hook-subcommand branch June 17, 2019 17:14
sowmyav24 pushed a commit to sowmyav24/ktlint that referenced this pull request Jun 22, 2019
Move old one (`--install-git-pre-commit-hook`) option to be a ktlint
subcommand - new syntax: `ktlint installGitPreCommitHook`. Old one
`--install-git-pre-commit-hook` is still working, but deprecated.

Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>
sowmyav24 pushed a commit to sowmyav24/ktlint that referenced this pull request Jun 22, 2019
Move old one (`--install-git-pre-commit-hook`) option to be a ktlint
subcommand - new syntax: `ktlint installGitPreCommitHook`. Old one
`--install-git-pre-commit-hook` is still working, but deprecated.

Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>
sowmyav24 pushed a commit to sowmyav24/ktlint that referenced this pull request Jun 22, 2019
Move old one (`--install-git-pre-commit-hook`) option to be a ktlint
subcommand - new syntax: `ktlint installGitPreCommitHook`. Old one
`--install-git-pre-commit-hook` is still working, but deprecated.

Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>
sowmyav24 pushed a commit to sowmyav24/ktlint that referenced this pull request Jun 22, 2019
Move old one (`--install-git-pre-commit-hook`) option to be a ktlint
subcommand - new syntax: `ktlint installGitPreCommitHook`. Old one
`--install-git-pre-commit-hook` is still working, but deprecated.

Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants