Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnnotationRule fixes/enhancements #624

Merged
merged 4 commits into from
Dec 3, 2019

Conversation

shashachu
Copy link
Contributor

@shashachu shashachu commented Oct 17, 2019

  • Fixing autoCorrect logic to ensure we're doing no work unless there is a lint violation
  • Restructuring code slightly to allow ktlint to do a more standard node traversal
  • Adding support for file annotations

    * Fixing autoCorrect loging to ensure we're doing no work unless there is a lint violation
    * Restructuring code slightly to allow ktlint to do a more standard node traversal
    * Adding support for file annotations
Copy link
Collaborator

@Tapchicoma Tapchicoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shashachu shashachu merged commit e0bc60c into pinterest:master Dec 3, 2019
@shashachu shashachu deleted the annotation-fix branch June 8, 2020 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants