Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build/tests on Windows #640

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Fix build/tests on Windows #640

merged 1 commit into from
Nov 11, 2019

Conversation

romtsn
Copy link
Collaborator

@romtsn romtsn commented Nov 9, 2019

Windows is ¯_(ツ)_/¯

Tapchicoma
Tapchicoma approved these changes Nov 11, 2019
View reviewed changes
Copy link
Collaborator

@Tapchicoma Tapchicoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing this 👍

@Tapchicoma Tapchicoma merged commit 681df30 into pinterest:master Nov 11, 2019
@romtsn romtsn deleted the fix-tests-on-windows branch November 12, 2019 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tapchicoma Tapchicoma Tapchicoma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romtsn @Tapchicoma