KtLint: Make functions needed to calculate line / column public #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sschuberth Apologies for the delay. Can you try rebasing and re-pushing your PR? looks like something went wrong with the checks. |
In order to avoid duplicating code, make these functions public for use by tools that use KtLint programmatically and need to convert an offset to line / column, like detekt.
sschuberth
force-pushed
the
public-offset-to-line-column
branch
from
3096f92
to
a387c0f
Compare
|
Done @shashachu. |
sschuberth
added a commit
to sschuberth/detekt
that referenced
this pull request
Jun 3, 2020
These functions formerly were private but are public now, see pinterest/ktlint#725.
arturbosch
pushed a commit
to detekt/detekt
that referenced
this pull request
Jun 3, 2020
* Upgrade ktlint to version 0.37.0 See https://github.com/pinterest/ktlint/releases/tag/0.37.0. Note that IndentationRule was promoted to standard. * Use helper functions directly from ktlint instead of copies These functions formerly were private but are public now, see pinterest/ktlint#725.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid duplicating code, make these functions public for use
by tools that use KtLint programmatically and need to convert an offset
to line / column, like detekt.