Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnnotationRule: don't report if a comment is placed after the last annotation #740

Merged
merged 2 commits into from
May 19, 2020

Conversation

t-kameyama
Copy link
Contributor

Fixes #736

@shashachu
Copy link
Contributor

@t-kameyama thanks for the PR. Can you confirm that

@Annotation1 // comment 1
@Annotation2
class MyClass {
}

passes with no errors as well? I believe it should based on the bug report but I'd like to confirm. Apologies if this is already covered in test cases.

@t-kameyama
Copy link
Contributor Author

Added a test.

@shashachu shashachu merged commit 5fa5262 into pinterest:master May 19, 2020
@shashachu
Copy link
Contributor

thank you!

@t-kameyama t-kameyama deleted the issue_736 branch May 19, 2020 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comment after annotations are interpreted as the annotated construct.
2 participants