Delegate loading .editorconfig properties to ec4j library. #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tapchicoma
commented
May 30, 2020
Tapchicoma
force-pushed
the
rework-editorconfig-loading
branch
from
6c024c9
to
20e1a83
Compare
|
FYI: |
romtsn
approved these changes
May 30, 2020
ktlint-core/src/main/kotlin/com/pinterest/ktlint/core/internal/EditorConfigLoader.kt
Outdated
Show resolved
Hide resolved
| /** | ||
| * In-memory [Cache] implementation that could be safely accessed from any [Thread]. | ||
| */ | ||
| internal class ThreadSafeEditorConfigCache : Cache { |
There was a problem hiding this comment.
not sure if it's worth to test this class?
There was a problem hiding this comment.
It is pretty straightforward, but I will add some tests 👍
There was a problem hiding this comment.
After some thoughts I've decided to not write tests for this class. Class itself is pretty straightforward, though writing non-flaky multithreading tests are hard and not worth, in this particular case, an effort.
Tapchicoma
force-pushed
the
rework-editorconfig-loading
branch
from
20e1a83
to
4f9083b
Compare
Remove custom logic how to load and cache editorconfig properties for specific file and use ec4j library for it. For now implementation just uses raw properties values. In the future, we could use custom Properties to also do validation of .editorconfig. Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove custom logic how to load and cache editorconfig properties for specific file and use ec4j library for it.
For now implementation just uses raw properties values. In the future, we could use custom Properties to also do validation of .editorconfig.
Fixes #742