Add experimental SpacingAroundAngleBracketsRule #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new angle bracket rule will live in the experimental rule set along with all the other new rules, so this commit refactors the associated tests to also live under the experimental package
Adds a rule to lint against white space before and after angle brackets in type arguments. This includes all of the following: Map< String, Int> Map<String, Int > Map <String, Int> In all of the above cases, the desired format is Map<String, Int> Specifically this rule does not affect generics formatting of the type fun myFun<T>() as this is already implemented in a separate rule.
The new angle bracket rule will live in the experimental rule set along with all the other new rules, so this commit refactors the associated tests to also live under the experimental package
Adds a rule to lint against white space before and after angle brackets in type arguments. This includes all of the following: Map< String, Int> Map<String, Int > Map <String, Int> In all of the above cases, the desired format is Map<String, Int> Specifically this rule does not affect generics formatting of the type fun myFun<T>() as this is already implemented in a separate rule.
romtsn
reviewed
Jun 6, 2020
.../src/main/kotlin/com/pinterest/ktlint/ruleset/experimental/SpacingAroundAngleBracketsRule.kt
Show resolved
Hide resolved
.../src/main/kotlin/com/pinterest/ktlint/ruleset/experimental/SpacingAroundAngleBracketsRule.kt
Outdated
Show resolved
Hide resolved
romtsn
approved these changes
Jun 9, 2020
This was referenced Jun 11, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on @christinalee's work in #587 (thanks so much, your PR was a perfect example of how to add new rules!)
In this PR, we created a lint rule to trim spacing around type parameters (
TYPE_PARAMETER_LIST) and type arguments (TYPE_ARGUMENT_LIST).Note that when the types span multiple lines, this rule does not fix the indentation itself. I rely on
IndentationRuleto dictate indentation. For example,is formatted to
The following shows that the indentation is fixed when all rules are run.