StringTemplateRule: don't report when template expression is keyword #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-kameyama
force-pushed
the
issue_883
branch
from
dcf1cef
to
65a264e
Compare
t-kameyama
force-pushed
the
issue_883
branch
from
65a264e
to
99b6880
Compare
romtsn
reviewed
Sep 5, 2020
| @@ -41,13 +46,15 @@ class StringTemplateRule : Rule("string-template") { | |||
| ) { | |||
| emit(dot.startOffset, "Redundant \"toString()\" call in string template", true) | |||
| if (autoCorrect) { | |||
| entryExpression = (entryExpression as? KtDotQualifiedExpression)?.receiverExpression | |||
There was a problem hiding this comment.
If this line is not exists, testFormat will fail because entryExpression is KtDotQualifiedExpression.
callExpression of dotQualifiedExpression will be removed in the next line, so we need to save receiverExpression in entryExpression.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #883