Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align with kotlin plugin on how subpackages are represented #998

Merged
merged 1 commit into from
Dec 12, 2020

Conversation

romtsn
Copy link
Collaborator

@romtsn romtsn commented Dec 7, 2020

Am not sure why they use a double star to indicate "with subpackages" behavior, and also, even when I specified a full path without subpackages and exported the .editorconfig file in IDEA, it still had a single star in it:

image

ij_kotlin_imports_layout = *,java.**,javax.**,kotlin.**,java.nio.file.Paths.*,^

Maybe this means "all members of an import" - don't know.

As usual source of truth: https://github.com/JetBrains/intellij-kotlin/blob/master/idea/src/org/jetbrains/kotlin/idea/formatter/KotlinPackageEntryTableAccessor.kt

@Tapchicoma
Copy link
Collaborator

Could you add a link to KotlinPackageEntryTableAccessor into ImportOrderingRule?

@romtsn
Copy link
Collaborator Author

romtsn commented Dec 12, 2020

Added, but rather to ImportLayoutParser as it's a better place for that link I think

@romtsn
Copy link
Collaborator Author

romtsn commented Dec 12, 2020

Part of #753

@romtsn romtsn merged commit cd6fb0b into pinterest:master Dec 12, 2020
@romtsn romtsn deleted the align-subpackages branch December 12, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants