fix: remove the edge when the node is deleted in dag exporter #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jczhong84
force-pushed
the
fix/reactflow
branch
from
49e6408 to
b5d9edb
Compare
czgu
approved these changes
Dec 5, 2022
lilyli9
pushed a commit
to lilyli9/querybook
that referenced
this pull request
Jan 26, 2023
### [0.45.1](https://github.expedia.biz/eg-analytics-platform/querybook/compare/0.45.0...0.45.1) (2022-12-09) ### Bug Fixes * boost table score for exact match when searching table (pinterest#1097) ([d75c1d1](https://github.expedia.biz/eg-analytics-platform/querybook/commit/d75c1d1d7089843465f6ecb0a6eb26b67b43c241)) * Keep table search default sort by name ([def3a0c](https://github.expedia.biz/eg-analytics-platform/querybook/commit/def3a0c9562c992d69db00185c7438d77980ebd2)) * notify_user need to accept user not uid (pinterest#1095) ([8b5b78f](https://github.expedia.biz/eg-analytics-platform/querybook/commit/8b5b78faa35bb2f6dfe7ebef7b3807af4befc3d3)) * remove python-dev from dockerfile build (pinterest#1098) ([12520df](https://github.expedia.biz/eg-analytics-platform/querybook/commit/12520df94c9a1543d9a6e726da4c009874ea8e5f)) * remove the edge when the node is deleted in dag exporter (pinterest#1089) ([d945a68](https://github.expedia.biz/eg-analytics-platform/querybook/commit/d945a68c92269a8f72a7b3331c2b186e2fcdb378)) * sidebar search should use relevance instead of alphabetical (pinterest#1096) ([a18cc93](https://github.expedia.biz/eg-analytics-platform/querybook/commit/a18cc93b49674b0d923ee32b724942cf194ad629))
rohan-sh1
pushed a commit
to CAI-TECHNOLOGIES/cai-ext-db-explorer
that referenced
this pull request
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When deleting a query cell by clicking the "X" hover icon in DAG exporter, the edge connecting to the node are not actually deleted. When the node is added back to the graph, the edge is still there.
Fix
The latest react-flow v11.3 provide a util function of
deleteElementsto help deleting an element, which will have the correct behavior. Here we're upgrading react-flow to v11 and use this function to do the node deleting.