Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stay on current env after deleting doc #1138

Conversation

lilyli9
Copy link
Contributor

@lilyli9 lilyli9 commented Jan 31, 2023

This fixes an issue where deleting a DataDoc in a non-default environment causes the UI to jump to the default environment instead of remaining in the current environment. The issue seems to be related to QB reloading after attempting to navigate to '{currentEnv.name}/datadoc' after deleting a datadoc. The change included in this PR avoids the reload while also refreshing the page to be able to see that the datadoc was deleted.

Copy link
Collaborator

@czgu czgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the issue is we are redirecting to root when deleting doc instead redirecting to env:

<Route path="/:env/datadoc/" exact={true}>
            <Redirect to="/" />
        </Route>

just leaving it as a note here. No change needed.

Thanks for fixing this bug!

@czgu czgu merged commit 07a8b62 into pinterest:master Jan 31, 2023
rohan-sh1 pushed a commit to CAI-TECHNOLOGIES/cai-ext-db-explorer that referenced this pull request Apr 11, 2023
Co-authored-by: Lily Li <lli6@expediagroup.com>
aidenprice pushed a commit to arrowtail-precision/querybook that referenced this pull request Jan 3, 2024
Co-authored-by: Lily Li <lli6@expediagroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants