feat: Add ability to cancel dead queries #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jczhong84
reviewed
Feb 11, 2023
|
|
||
| task = run_query_task.AsyncResult(execution.task_id) | ||
|
|
||
| if task.state == "PENDING": |
There was a problem hiding this comment.
celery task has another RECEIVED state, which also can be revoked. would be nice to add this case as well.
jczhong84
previously approved these changes
Feb 14, 2023
jczhong84
approved these changes
Feb 14, 2023
rohan-sh1
pushed a commit
to CAI-TECHNOLOGIES/cai-ext-db-explorer
that referenced
this pull request
Apr 11, 2023
* feat: Add ability to cancel read queries * resolved comments
aidenprice
pushed a commit
to arrowtail-precision/querybook
that referenced
this pull request
Jan 3, 2024
* feat: Add ability to cancel read queries * resolved comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously, we would just send abort signal to the execution. But if the query is not running in celery, then nothing would be done. This PR adds more checks on the API side to update query status if the execution itself is gone