Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: find the closed color in ColorPalette #1184

Merged
merged 7 commits into from
Feb 28, 2023

Conversation

jczhong84
Copy link
Collaborator

For unknown hex tag colors, we'll try to find the closest color in the ColorPalette.

Also fixed an issue of the owner type, which needs to return a dict instead of a named tuple.

querybook/webapp/lib/utils/color.ts Outdated Show resolved Hide resolved
querybook/webapp/lib/utils/color.ts Outdated Show resolved Hide resolved
querybook/webapp/ui/Tag/Tag.tsx Outdated Show resolved Hide resolved
querybook/server/models/admin.py Show resolved Hide resolved
@jczhong84 jczhong84 marked this pull request as draft February 28, 2023 09:01
@jczhong84 jczhong84 marked this pull request as ready for review February 28, 2023 18:40
@jczhong84 jczhong84 requested a review from czgu February 28, 2023 18:40
querybook/webapp/lib/utils/color.ts Outdated Show resolved Hide resolved
querybook/server/lib/utils/json.py Show resolved Hide resolved
querybook/server/logic/tag.py Outdated Show resolved Hide resolved
querybook/webapp/ui/Tag/Tag.tsx Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@czgu czgu merged commit 5ec6a4d into pinterest:master Feb 28, 2023
@jczhong84 jczhong84 deleted the feat/color branch April 7, 2023 00:41
rohan-sh1 pushed a commit to CAI-TECHNOLOGIES/cai-ext-db-explorer that referenced this pull request Apr 11, 2023
* feat: find the closed color in ColorPalette

* comments

* add back _asdict

* move color palette to yaml

* jest to load yaml

* remove hex color check

* move js-yaml to dev dependency
aidenprice pushed a commit to arrowtail-precision/querybook that referenced this pull request Jan 3, 2024
* feat: find the closed color in ColorPalette

* comments

* add back _asdict

* move color palette to yaml

* jest to load yaml

* remove hex color check

* move js-yaml to dev dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants