Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update the step by step guide of connecting to a query engine #1201

Merged
merged 3 commits into from
Mar 22, 2023

Conversation

jczhong84
Copy link
Collaborator

@jczhong84 jczhong84 commented Mar 20, 2023

also

  • fixes a build error from the helm deployment doc update.
  • add package psycopg2, as it is needed by PostgreSQL.

@jczhong84 jczhong84 requested a review from czgu March 20, 2023 23:35
@@ -44,6 +44,12 @@ Once a metastore is created, you can configure the auto sync schedule, manually

Query engine configures the endpoints that users can query. Each query engine needs to be attached to an environment for security measures. They can also attach a metastore to allow users to see table information while writing queries. All available query engine executors are grouped by language and each of them have different configuration values that needs to be set.

![](/img/documentation/Querybook_concepts.png)

- A query engine can be associated with a metastore.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A metastore can associate with one or more query engines?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to phrase this from the query engine's point of view, as the association happens on creating the query engine, not on the metastore view.

docs_website/docs/setup_guide/connect_to_a_query_engine.md Outdated Show resolved Hide resolved
postgresql://<username>:<password>@<server-host>:<port>/<database>
```
Please refer to the SqlAlchemy [documentation](https://docs.sqlalchemy.org/en/20/core/engines.html#postgresql) for the connection string format.
- Select `ConnectionChecker` as status checker
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

select 1 check is better for postgres?

Please refer to the SqlAlchemy [documentation](https://docs.sqlalchemy.org/en/20/core/engines.html#postgresql) for the connection string format.
- Select `ConnectionChecker` as status checker

:::caution About localhost
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this caution is the callout type.

@jczhong84 jczhong84 requested a review from czgu March 22, 2023 04:24
@czgu czgu merged commit 5ee43b0 into pinterest:master Mar 22, 2023
@jczhong84 jczhong84 deleted the docs/engine branch April 7, 2023 00:40
rohan-sh1 pushed a commit to CAI-TECHNOLOGIES/cai-ext-db-explorer that referenced this pull request Apr 11, 2023
…interest#1201)

* docs: update the step by step guide of connecting to a query engine

* link to general config

* comments and add psycopg2
aidenprice pushed a commit to arrowtail-precision/querybook that referenced this pull request Jan 3, 2024
…interest#1201)

* docs: update the step by step guide of connecting to a query engine

* link to general config

* comments and add psycopg2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants