fix: Fix DataDoc contents overflow in non-Chrome browsers #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jczhong84
approved these changes
Sep 20, 2023
jczhong84
added a commit
to jczhong84/querybook
that referenced
this pull request
Sep 21, 2023
…nterest#1332)" This reverts commit 18c86a6.
aidenprice
pushed a commit
to arrowtail-precision/querybook
that referenced
this pull request
Jan 3, 2024
aidenprice
pushed a commit
to arrowtail-precision/querybook
that referenced
this pull request
Jan 3, 2024
…nterest#1332)" (pinterest#1336) This reverts commit 18c86a6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataDocs with wide result tables cause the entire page to scroll horizontally:
Before:
This isn't an issue in Chrome because there's a special case hardcoded for it in DataDocContentContainer.
This PR fixes the issue by enabling overflow for
.data-doc-content-container, and doesn't break anything for Chrome.Tested this change in Firefox and Safari.
After:
