feat: ask users to confirm tables before query generation #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czgu
reviewed
Sep 26, 2023
querybook/webapp/components/AIAssistant/QueryGenerationModal.tsx
Outdated
Show resolved
Hide resolved
querybook/webapp/components/AIAssistant/QueryGenerationModal.tsx
Outdated
Show resolved
Hide resolved
| openTableModal?: () => any; | ||
| } | ||
|
|
||
| export const TableTooltip: React.FunctionComponent<IProps> = ({ | ||
| table, | ||
| columns, | ||
| schema, | ||
| showPinItButton = true, |
There was a problem hiding this comment.
just default it to false, since i saw its false below
There was a problem hiding this comment.
this will be used by other place, like the query editor tooltip, which is true. just to not breaking them without updating them.
There was a problem hiding this comment.
in this case, we can rename this to hidePinItButton and default to False, and have whatever is calling TableTooltipByName to pass that as True
czgu
approved these changes
Sep 26, 2023
aidenprice
pushed a commit
to arrowtail-precision/querybook
that referenced
this pull request
Jan 3, 2024
…1339) * feat: ask users to confirm tables before text2sql * comments * hidePitItButton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When AI finds tables for the question, it generates the query using those tables directly without asking user.
Now we are changing it to ask user to confirm the tables before query generation.
text2sql_tables_v2.mp4