Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gevent for celery worker, update timeout to GeventTimeout #1345

Merged
merged 4 commits into from
Oct 12, 2023
Merged

Use gevent for celery worker, update timeout to GeventTimeout #1345

merged 4 commits into from
Oct 12, 2023

Conversation

czgu
Copy link
Collaborator

@czgu czgu commented Oct 11, 2023 •
edited
Loading

Resolves #1337

  • The Timeout function previously would crash celery worker due to the way exception was raised
  • Instead, we now use gevent timeout paired with gevent worker
  • The old timeout is kept as is incase it breaks any downstream code

meowcodes
meowcodes previously approved these changes Oct 11, 2023
View reviewed changes
@czgu czgu merged commit 7480a64 into pinterest:master Oct 12, 2023
4 checks passed
@czgu czgu deleted the hotfix branch October 12, 2023 03:25
aidenprice pushed a commit to arrowtail-precision/querybook that referenced this pull request Jan 3, 2024
@czgu @aidenprice
Use gevent for celery worker, update timeout to GeventTimeout (pinter…
d986dfd 
…est#1345)

* hotfix for worker starting up

* Use gevent for celery worker, update timeout to GeventTimeout

* Use gevent for celery worker, update timeout to GeventTimeout

* Default back to multiprocess worker, but with Timeout dynamic for gevent and non-gevent cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yfdo yfdo yfdo approved these changes

@meowcodes meowcodes meowcodes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timed out waiting for UP message from ForkProcess
3 participants
@czgu @meowcodes @yfdo