Add query execution links to exporter results #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jczhong84
reviewed
Nov 7, 2023
| statement_execution_id | ||
| ) | ||
| query_execution_id = statement_execution.query_execution_id | ||
| return f"{QuerybookSettings.PUBLIC_URL}/query_execution/{query_execution_id}" |
There was a problem hiding this comment.
I think there is an env in the url. e.g. querybook.pinadmin.com/data/query_execution
There was a problem hiding this comment.
thanks, good catch
jczhong84
reviewed
Nov 7, 2023
| def _save_sheet_to_statement_meta(self, sheet_url: str, statement_id: int): | ||
| statement_execution = get_statement_execution_by_id(statement_id) | ||
| meta_info = ( | ||
| statement_execution.meta_info or "" |
There was a problem hiding this comment.
does statement_execution.meta_info end with \n?
There was a problem hiding this comment.
looks like we add a \n at the end of every line for meta_info in querybook
jczhong84
previously approved these changes
Nov 8, 2023
jczhong84
approved these changes
Nov 9, 2023
aidenprice
pushed a commit
to arrowtail-precision/querybook
that referenced
this pull request
Jan 3, 2024
* Add query execution links to exporter results * fix pr comments * update python version in lint workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google sheets export:
Python export: