Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade langchain version #1406

Merged
merged 4 commits into from
Feb 14, 2024
Merged

feat: upgrade langchain version #1406

merged 4 commits into from
Feb 14, 2024

Conversation

jczhong84
Copy link
Collaborator

@jczhong84 jczhong84 commented Feb 3, 2024 •
edited
Loading

  • Upgrade langchain to 0.1.6
  • Adopt the new streaming approach which support partial json streaming and remove the old streaming code
  • Also add non streaming support
  • Split sql edit from the text-to-sql prompt

kgopal492
kgopal492 previously approved these changes Feb 6, 2024
View reviewed changes
baumandm
baumandm reviewed Feb 14, 2024
View reviewed changes
Copy link
Contributor

@baumandm baumandm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out on our side. Found one small issue with non-streaming mode, but otherwise it works great! 👍

querybook/server/lib/ai_assistant/base_ai_assistant.py Outdated Show resolved Hide resolved
querybook/webapp/components/AIAssistant/QueryGenerationModal.tsx Outdated Show resolved Hide resolved
@czgu czgu merged commit 7208c05 into pinterest:master Feb 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baumandm baumandm baumandm left review comments

@czgu czgu czgu approved these changes

@kgopal492 kgopal492 kgopal492 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jczhong84 @baumandm @czgu @kgopal492