Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix selection behavior #341

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Fix selection behavior #341

merged 1 commit into from
Dec 8, 2020

Conversation

czgu
Copy link
Collaborator

@czgu czgu commented Dec 8, 2020

  • Allow de-select metastore, previously it errors out due to deselect value being "" instead of null
  • Ensure table tag selection is cleared after select for better UX
  • Added test cases for Select.tsx

@czgu czgu requested a review from meowcodes December 8, 2020 16:51
@meowcodes meowcodes merged commit ea94821 into master Dec 8, 2020
@meowcodes meowcodes deleted the smallfix branch December 8, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meowcodes meowcodes meowcodes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@czgu @meowcodes