Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs website message, add alt to img #343

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Update docs website message, add alt to img #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions docs_website/src/components/HomePage/FeatureSection/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import Heading from '../../Heading';
import './index.scss';
import ImageModal from '../../ImageModal';

const Image = ({ url, className }) => (
<img className={className ?? ''} src={useBaseUrl(`img/${url}`)} />
const Image = ({ url, className, alt }) => (
<img className={className ?? ''} src={useBaseUrl(`img/${url}`)} alt={alt} />
);

export default ({ featureType = 'key' }) => {
Expand Down Expand Up @@ -53,6 +53,9 @@ export default ({ featureType = 'key' }) => {
featureConfig.featureItems[imageIndex]
.imageClassName
}
alt={
featureConfig.featureItems[imageIndex].title
}
/>
</ImageModal>
</div>
Expand Down
7 changes: 4 additions & 3 deletions docs_website/src/components/HomePage/HeaderSection/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,10 @@ export default () => {
</div>

<div className="container">
<p className="used-by text">
Used by Engineers and Data Scientists From
</p>
<div className="used-by text">
<p>Announced in Dec 2020</p>
<p>Used by Engineers and Data Scientists From</p>
</div>
<div className="flex-center used-by-logos">
<Link to="https://www.pinterest.com">
<img
Expand Down
5 changes: 4 additions & 1 deletion docs_website/src/components/HomePage/HeaderSection/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,10 @@
animation: fadeIn 1s ease-in-out backwards;
animation-delay: 1s;

margin-bottom: 0.5rem;
margin-bottom: var(--ifm-paragraph-margin-bottom);
p {
margin-bottom: 0;
}
}

.used-by-logos {
Expand Down
12 changes: 10 additions & 2 deletions docs_website/src/components/HomePage/IntegrationsSection/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@ export default () => {
itemPerRow={4}
renderer={(item) => (
<div className="logo-container">
<img src={`img/${item.image}`} height={'80px'} />
<img
src={`img/${item.image}`}
height={'80px'}
alt={item.key}
/>
</div>
)}
itemClassName={'logo-item'}
Expand All @@ -36,7 +40,11 @@ export default () => {
itemPerRow={4}
renderer={(item) => (
<div className="logo-container">
<img src={`img/${item.image}`} height={'80px'} />
<img
src={`img/${item.image}`}
height={'80px'}
alt={item.key}
/>
</div>
)}
itemClassName={'logo-item'}
Expand Down