Remove dead code / unused references

datahub/webapp/__tests__/ui/__snapshots__/Message.test.js.snap

@@ -2,6 +2,7 @@
 
 exports[`matches enzyme snapshots matches snapshot - error 1`] = `
 <Message
+  className=""
   title="Error"
   type="error"
 >

datahub/webapp/components/AppAdmin/AdminAnnouncement.scss

@@ -22,7 +22,7 @@
                 border: var(--border);
                 margin: 8px 0px;
                 padding: 16px;
-                .SingleCRUD {
+                .GenericCRUD {
                     width: 100%;
                 }
             }

datahub/webapp/components/AppAdmin/AdminAnnouncement.tsx

@@ -7,7 +7,7 @@ import { useDataFetch } from 'hooks/useDataFetch';
 
 import { Card } from 'ui/Card/Card';
 import { Icon } from 'ui/Icon/Icon';
-import { SingleCRUD } from 'ui/GenericCRUD/SingleCRUD';
+import { GenericCRUD } from 'ui/GenericCRUD/GenericCRUD';
 import { Loading } from 'ui/Loading/Loading';
 import { SimpleField } from 'ui/FormikField/SimpleField';
 
@@ -76,10 +76,7 @@ export const AdminAnnouncement: React.FunctionComponent = () => {
         []
     );
 
-    const renderAnnouncementItem = (
-        item: IAdminAnnouncement,
-        onChange: (fieldName: string, fieldValue: any) => void
-    ) => (
+    const renderAnnouncementItem = () => (
         <div className="AdminForm">
             <div className="AdminForm-main">
                 <div className="AdminForm-left">
@@ -114,7 +111,7 @@ export const AdminAnnouncement: React.FunctionComponent = () => {
     const getCardDOM = () =>
         announcements.map((ann) => (
             <Card key={ann.id} title="" width="100%" flexRow>
-                <SingleCRUD
+                <GenericCRUD
                     item={ann}
                     deleteItem={deleteAnnouncement}
                     updateItem={saveAnnouncement(ann.id)}
@@ -129,7 +126,7 @@ export const AdminAnnouncement: React.FunctionComponent = () => {
         if (displayNewForm) {
             return (
                 <div className="AdminAnnouncement-new-form horizontal-space-between">
-                    <SingleCRUD<Partial<IAdminAnnouncement>>
+                    <GenericCRUD<Partial<IAdminAnnouncement>>
                         item={{
                             message: undefined,
                             url_regex: undefined,

datahub/webapp/components/AppAdmin/AdminEnvironment.tsx

@@ -14,7 +14,7 @@ import { UserEnvironmentEditor } from 'components/UserEnvironmentEditor/UserEnvi
 import { AdminAuditLogButton } from 'components/AdminAuditLog/AdminAuditLogButton';
 
 import { Card } from 'ui/Card/Card';
-import { SingleCRUD } from 'ui/GenericCRUD/SingleCRUD';
+import { GenericCRUD } from 'ui/GenericCRUD/GenericCRUD';
 import { Level } from 'ui/Level/Level';
 import { SimpleField } from 'ui/FormikField/SimpleField';
 
@@ -109,10 +109,7 @@ export const AdminEnvironment: React.FunctionComponent<IProps> = ({
         return data as IAdminEnvironment;
     }, []);
 
-    const renderEnvironmentItem = (
-        item: IAdminEnvironment,
-        onChange: (fieldName: string, fieldValue: any) => void
-    ) => {
+    const renderEnvironmentItem = (item: IAdminEnvironment) => {
         const logDOM = item.id != null && (
             <div className="right-align">
                 <AdminAuditLogButton itemType="environment" itemId={item.id} />
@@ -199,7 +196,7 @@ export const AdminEnvironment: React.FunctionComponent<IProps> = ({
         return (
             <div className="AdminEnvironment">
                 <div className="AdminForm">
-                    <SingleCRUD
+                    <GenericCRUD
                         item={newEnvironment}
                         createItem={createEnvironment}
                         renderItem={renderEnvironmentItem}
@@ -248,7 +245,7 @@ export const AdminEnvironment: React.FunctionComponent<IProps> = ({
         return (
             <div className="AdminEnvironment">
                 <div className="AdminForm">
-                    <SingleCRUD
+                    <GenericCRUD
                         item={environmentItem}
                         deleteItem={deleteEnvironment}
                         updateItem={saveEnvironment}

datahub/webapp/components/AppAdmin/AdminMetastore.tsx

@@ -21,7 +21,7 @@ import { Icon } from 'ui/Icon/Icon';
 import { Level } from 'ui/Level/Level';
 import { Loading } from 'ui/Loading/Loading';
 import { SimpleField } from 'ui/FormikField/SimpleField';
-import { SingleCRUD } from 'ui/GenericCRUD/SingleCRUD';
+import { GenericCRUD } from 'ui/GenericCRUD/GenericCRUD';
 import {
     TemplatedForm,
     getDefaultFormValue,
@@ -33,11 +33,6 @@ import { Tabs } from 'ui/Tabs/Tabs';
 
 import './AdminMetastore.scss';
 
-const metastoreSchema = Yup.object().shape({
-    name: Yup.string().min(1).max(255),
-    loader: Yup.string().required(),
-});
-
 interface IAdminACLControl {
     type?: 'denylist' | 'allowlist';
     tables?: string[];
@@ -424,7 +419,7 @@ export const AdminMetastore: React.FunctionComponent<IProps> = ({
             return (
                 <div className="AdminMetastore">
                     <div className="AdminForm">
-                        <SingleCRUD
+                        <GenericCRUD
                             item={newMetastore}
                             createItem={createMetastore}
                             renderItem={renderMetastoreItem}
@@ -477,7 +472,7 @@ export const AdminMetastore: React.FunctionComponent<IProps> = ({
             return (
                 <div className="AdminMetastore">
                     <div className="AdminForm">
-                        <SingleCRUD
+                        <GenericCRUD
                             item={metastoreItem}
                             deleteItem={deleteMetastore}
                             onDelete={() => history.push('/admin/metastore/')}

datahub/webapp/components/AppAdmin/AdminQueryEngine.tsx

@@ -12,7 +12,7 @@ import { AdminAuditLogButton } from 'components/AdminAuditLog/AdminAuditLogButto
 
 import { Card } from 'ui/Card/Card';
 import { Loading } from 'ui/Loading/Loading';
-import { SingleCRUD } from 'ui/GenericCRUD/SingleCRUD';
+import { GenericCRUD } from 'ui/GenericCRUD/GenericCRUD';
 import {
     SmartForm,
     TemplatedForm,
@@ -383,7 +383,7 @@ export const AdminQueryEngine: React.FunctionComponent<IProps> = ({
             return (
                 <div className="AdminQueryEngine">
                     <div className="AdminForm">
-                        <SingleCRUD
+                        <GenericCRUD
                             item={newQueryEngine}
                             createItem={createQueryEngine}
                             renderItem={renderQueryEngineItem}
@@ -436,7 +436,7 @@ export const AdminQueryEngine: React.FunctionComponent<IProps> = ({
             return (
                 <div className="AdminQueryEngine">
                     <div className="AdminForm">
-                        <SingleCRUD
+                        <GenericCRUD
                             item={queryEngineItem}
                             deleteItem={deleteQueryEngine}
                             updateItem={saveQueryEngine}

datahub/webapp/components/AppAdmin/AppAdmin.scss

@@ -152,7 +152,7 @@
         }
     }
 
-    .SingleCRUD-invalid-msg {
+    .GenericCRUD-invalid-msg {
         margin-left: 8px;
     }
 

datahub/webapp/components/BoardItemAddButton/BoardItemAddButton.tsx

@@ -9,7 +9,7 @@ import { TooltipDirection } from 'const/tooltip';
 import { useDataFetch } from 'hooks/useDataFetch';
 
 import { IconButton, IconButtonProps } from 'ui/Button/IconButton';
-import { BoardItemType, IBoard, IBoardRaw } from 'const/board';
+import { BoardItemType, IBoardRaw } from 'const/board';
 
 import { Popover, PopoverLayout } from 'ui/Popover/Popover';
 import { BoardCreateUpdateModal } from 'components/BoardCreateUpdateModal/BoardCreateUpdateModal';

datahub/webapp/components/BoardList/BoardList.tsx

@@ -1,4 +1,4 @@
-import React, { useEffect, useState, useMemo, useRef } from 'react';
+import React, { useEffect, useState, useMemo } from 'react';
 import { useDispatch, useSelector } from 'react-redux';
 import classNames from 'classnames';
 
@@ -9,9 +9,8 @@ import { SearchBar } from 'ui/SearchBar/SearchBar';
 import { IconButton } from 'ui/Button/IconButton';
 import { BoardCreateUpdateModal } from 'components/BoardCreateUpdateModal/BoardCreateUpdateModal';
 import { InfinityScroll } from 'ui/InfinityScroll/InfinityScroll';
-import { Icon } from 'ui/Icon/Icon';
-import './BoardList.scss';
 import { ListLink } from 'ui/Link/ListLink';
+import './BoardList.scss';
 
 interface IProps {
     onBoardClick: (id: IBoard) => any;

datahub/webapp/components/DataDoc/DataDoc.tsx

@@ -800,7 +800,7 @@ function mapStateToProps(state: IStoreState, ownProps: IOwnProps) {
     };
 }
 
-function mapDispatchToProps(dispatch: Dispatch, ownProps: IOwnProps) {
+function mapDispatchToProps(dispatch: Dispatch) {
     return {
         openDataDoc: (id: number) => dispatch(openDataDoc(id)),
         closeDataDoc: (id: number) => dispatch(closeDataDoc(id)),

datahub/webapp/components/DataDoc/DataDocContentContainer.tsx

@@ -1,4 +1,4 @@
-import React, { useEffect, useState, useCallback } from 'react';
+import React, { useState, useCallback } from 'react';
 import { useResizeObserver } from 'hooks/useResizeObserver';
 
 const isChrome = /chrome/.test(navigator.userAgent.toLowerCase());

datahub/webapp/components/DataDocChartCell/DataDocChartCell.tsx

@@ -38,11 +38,6 @@ interface IProps {
     onDownKeyPressed?: () => any;
     onDeleteKeyPressed?: () => any;
 }
-interface IState {
-    queryExecutionId?: number;
-    statementExecutionId?: number;
-    showChartComposer: boolean;
-}
 
 export const DataDocChartCell: React.FunctionComponent<IProps> = ({
     context,

datahub/webapp/components/DataDocLeftSidebar/DataDocContents.tsx

@@ -1,4 +1,4 @@
-import React, { useMemo, useRef, useCallback } from 'react';
+import React, { useMemo, useRef } from 'react';
 
 import { scrollToCell } from 'lib/data-doc/data-doc-utils';
 import { IDataCell } from 'const/datadoc';
@@ -8,7 +8,6 @@ import { moveDataDocCell } from 'redux/dataDoc/action';
 import { getScrollParent } from 'lib/utils';
 
 import './DataDocContents.scss';
-import { IDragItem } from 'ui/DraggableList/types';
 
 const CELL_TEXT_LEN = 50;
 

datahub/webapp/components/DataDocNavigator/DataDocNavigator.tsx

@@ -27,7 +27,6 @@ import {
 import { useDrop } from 'react-dnd';
 import { DataDocDraggableType, BoardDraggableType } from './navigatorConst';
 import { IDragItem } from 'ui/DraggableList/types';
-import { IBoardItem } from 'const/board';
 
 export const DataDocNavigator: React.FC = () => {
     const loadedFilterModes = useSelector(

datahub/webapp/components/DataDocSchedule/DataDocScheduleRunLogs.tsx

@@ -1,5 +1,4 @@
 import React from 'react';
-import moment from 'moment';
 
 import { ITaskStatusRecord } from 'const/schedule';
 import { generateFormattedDate } from 'lib/utils/datetime';

datahub/webapp/components/DataDocStatementExecution/DataDocStatementExecution.tsx

@@ -1,4 +1,4 @@
-import React, { useEffect, useMemo, useState } from 'react';
+import React, { useEffect, useMemo } from 'react';
 
 import { StatementExecutionStatus } from 'const/queryExecution';
 

datahub/webapp/components/DataDocTextCell/DataDocTextCell.tsx

@@ -4,7 +4,6 @@ import React, {
     useRef,
     useEffect,
     useCallback,
-    useMemo,
     useContext,
 } from 'react';
 import classNames from 'classnames';

datahub/webapp/components/DataDocViewersBadge/DataDocViewersBadge.tsx

@@ -1,4 +1,3 @@
-import classNames from 'classnames';
 import { bind } from 'lodash-decorators';
 import { connect } from 'react-redux';
 import React from 'react';
@@ -7,7 +6,6 @@ import { IStoreState, Dispatch } from 'redux/store/types';
 import * as dataDocActions from 'redux/dataDoc/action';
 import * as dataDocSelectors from 'redux/dataDoc/selector';
 
-import { UserAvatar } from 'components/UserBadge/UserAvatar';
 import { DataDocViewersList } from 'components/DataDocViewersList/DataDocViewersList';
 import './DataDocViewersBadge.scss';
 import { Popover } from 'ui/Popover/Popover';

datahub/webapp/components/DataTableTags/DataTableTags.tsx

@@ -7,7 +7,6 @@ import {
     fetchTableTagItemsIfNeeded,
     deleteTableTagItem,
 } from 'redux/tag/action';
-import * as searchActions from 'redux/search/action';
 import { navigateWithinEnv } from 'lib/utils/query-string';
 
 import { CreateDataTableTag } from './CreateDataTableTag';

datahub/webapp/components/DataTableViewColumn/DataTableViewColumn.tsx

@@ -17,10 +17,6 @@ export interface IDataTableViewColumnProps {
     ) => any;
 }
 
-export interface IDataTableViewColumnState {
-    filterString: string;
-}
-
 export const DataTableViewColumn: React.FunctionComponent<IDataTableViewColumnProps> = ({
     updateDataColumnDescription,
     table = null,

datahub/webapp/components/DataTableViewMini/PanelSection.tsx

@@ -5,9 +5,6 @@ export interface IPanelSectionProps {
     title: string;
     hideIfNoContent?: boolean;
 }
-export interface IPanelSectionState {
-    isOpen: boolean;
-}
 
 const PanelContentWrapper = styled.div`
     padding: 5px 32px;

datahub/webapp/components/DataTableViewSourceQuery/DataTableViewSourceQuery.tsx

@@ -29,10 +29,6 @@ export interface IProps {
     loadDataJobMetadata: (id: number) => any;
 }
 
-export interface IState {
-    parentTableIds: number[];
-}
-
 export const DataTableViewSourceQuery: React.FunctionComponent<IProps> = ({
     dataLineages,
     table,