-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebook fixes #1201
Notebook fixes #1201
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1201 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 82 82
Lines 8254 8254
=========================================
Hits 8254 8254
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In residuals-autocorrelation.ipynb, the Lotka-Volterra example was randomly failing on some runs due to a bad initial condition far away from the true parameter values (it would still have worked eventually, but with more MCMC iterations than we were doing in the notebooks). I moved the initial condition slightly closer to the true values, which seems to give a consistent correct result with the same number of iterations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry my bad for removing the rhat_all_params
function instead of deprecating it.
Looks good to me, I have difficulties to figure out what has changed in the constant_and_multiplicative notebook though :D
No worries!
Yeah github doens't like notebooks much (they contain embedded images, which makes github think there's a massive change). Changes to the notebook are small: just moved the imports around and made sure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @MichaelClerx for catching this
Three(!) notebooks were failing.
The nuts one failed because
rhat_all_params
had been removed from the API (not deprecated), so fixed that as well