Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook fixes #1201

Merged
merged 6 commits into from
Sep 3, 2020
Merged

Notebook fixes #1201

merged 6 commits into from
Sep 3, 2020

Conversation

MichaelClerx
Copy link
Member

Three(!) notebooks were failing.

The nuts one failed because rhat_all_params had been removed from the API (not deprecated), so fixed that as well

@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #1201 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1201   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           82        82           
  Lines         8254      8254           
=========================================
  Hits          8254      8254           
Impacted Files Coverage Δ
pints/__init__.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5b0374...fd46954. Read the comment docs.

@MichaelClerx MichaelClerx marked this pull request as ready for review September 2, 2020 09:16
Copy link
Contributor

@rccreswell rccreswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In residuals-autocorrelation.ipynb, the Lotka-Volterra example was randomly failing on some runs due to a bad initial condition far away from the true parameter values (it would still have worked eventually, but with more MCMC iterations than we were doing in the notebooks). I moved the initial condition slightly closer to the true values, which seems to give a consistent correct result with the same number of iterations.

Copy link
Member

@DavAug DavAug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry my bad for removing the rhat_all_params function instead of deprecating it.

Looks good to me, I have difficulties to figure out what has changed in the constant_and_multiplicative notebook though :D

@MichaelClerx
Copy link
Member Author

Sorry my bad for removing the rhat_all_params function instead of deprecating it.

No worries!

Looks good to me, I have difficulties to figure out what has changed in the constant_and_multiplicative notebook though :D

Yeah github doens't like notebooks much (they contain embedded images, which makes github think there's a massive change).
You can check it out with a local client (I use meld) by doing git difftool master. You need to tell it which tool though, which is something I always google :D

Changes to the notebook are small: just moved the imports around and made sure pints.plot was imported. It's important to always restart and re-run the notebook before submitting the final one: sometimes you've deleted a crucial import or variable from the notebook but it still works because it's remembered in the state

Copy link
Member

@martinjrobins martinjrobins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @MichaelClerx for catching this

@MichaelClerx MichaelClerx merged commit 9ee7b03 into master Sep 3, 2020
@MichaelClerx MichaelClerx deleted the notebook-fixes branch September 3, 2020 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants