Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log-normal log-likelihood #1378

Merged
merged 15 commits into from
Aug 11, 2022
Merged

Log-normal log-likelihood #1378

merged 15 commits into from
Aug 11, 2022

Conversation

ben18785
Copy link
Collaborator

@ben18785 ben18785 commented Aug 6, 2021

Adds a log-normal distribution both without (default) and with mean-adjustment as described in #1376

@ben18785 ben18785 requested a review from DavAug August 6, 2021 21:30
@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #1378 (c69a748) into master (2afaee9) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1378   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           95        95           
  Lines         9282      9321   +39     
=========================================
+ Hits          9282      9321   +39     
Impacted Files Coverage Δ
pints/__init__.py 100.00% <ø> (ø)
pints/_log_likelihoods.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@DavAug DavAug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good @ben18785 ! I like the Boolean for switching between the means. I just have a couple minor comments and a general comment on testing.

pints/_log_likelihoods.py Show resolved Hide resolved
pints/_log_likelihoods.py Outdated Show resolved Hide resolved
pints/tests/test_log_likelihoods.py Show resolved Hide resolved
@MichaelClerx
Copy link
Member

@ben18785 @DavAug this is approved. Want to merge it in now?

@MichaelClerx MichaelClerx merged commit 7194881 into master Aug 11, 2022
@MichaelClerx MichaelClerx deleted the i1376-lognormal-loglikelihood branch August 11, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants