Stop using triangle wave transform in optimisations #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…O using triangle transform
MichaelClerx
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1424 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 87 87
Lines 8950 8899 -51
=========================================
- Hits 8950 8899 -51
Continue to review full report at Codecov.
|
mirams
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #25 (and #1420)
It leads to errors with xnes, where it just keeps increasing sigma because it keeps finding points in the next "period" of the search space. The
TriangleWaveTransformis used by PSO, xNES, SNES, and BareCMAES. All of these methods can easily deal with "inf" for any evaluation, and this was already the way we handled arbitrary shaped boundaries.In addition, found and fixed a bug in PSO where we (I) initialised with too many particles