Change writeTo failed log level to info #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #252 decide to ignore the writeTo failed error with a log, application can choose callback and query state for the connection state. But if application keep sending packet during try icerestart to recover from ICEFailed, the warn log is annoying since the error is not critical and no need to process. So change it to info.
Codecov ReportBase: 77.83% // Head: 78.02% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #487 +/- ##
==========================================
+ Coverage 77.83% 78.02% +0.18%
==========================================
Files 36 36
Lines 4237 4237
==========================================
+ Hits 3298 3306 +8
+ Misses 730 725 -5
+ Partials 209 206 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
boks1971
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #252 decide to ignore the writeTo failed error with a log, application can choose callback and query state for the connection state. But if application keep sending packet during try ice restart to recover from ICEFailed, the warn log is annoying since the error is not critical and no need to process. So change it to info.
Description
When application get ice failed and try negotiation with ice restart to recover from failed state, but keep sending packets during recover, there will be a bunch of
use of closed network connectionwarn log.Reference issue
#252