Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade malgo to v0.11.10 #455

Merged
merged 3 commits into from
Dec 5, 2022
Merged

upgrade malgo to v0.11.10 #455

merged 3 commits into from
Dec 5, 2022

Conversation

edaniels
Copy link
Member

@edaniels edaniels commented Nov 21, 2022

brings a host of fixes and gets rid of a pesky issue on macos

@edaniels edaniels requested a review from at-wat November 21, 2022 19:07
@edaniels
Copy link
Member Author

edaniels commented Nov 21, 2022

Tested against https://github.com/edaniels/gostream/blob/master/cmd/stream_audio/main.go with playback to speaker via malgo and it works great still

@codecov
Copy link

codecov bot commented Dec 4, 2022

Codecov Report

Base: 58.15% // Head: 58.15% // No change to project coverage 👍

Coverage data is based on head (e7499a5) compared to base (a0f090d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #455   +/-   ##
=======================================
  Coverage   58.15%   58.15%           
=======================================
  Files          62       62           
  Lines        3680     3680           
=======================================
  Hits         2140     2140           
  Misses       1413     1413           
  Partials      127      127           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@edaniels edaniels merged commit cb23f1f into pion:master Dec 5, 2022
@edaniels edaniels deleted the upgrade_malgo branch December 5, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant