Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose device name and bus info #494

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Conversation

bazile-clyde
Copy link
Collaborator

Description

This PR exposes the device name and bus info for Linux cameras.

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: +0.02 🎉

Comparison is base (30badd8) 58.83% compared to head (7eb111f) 58.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #494      +/-   ##
==========================================
+ Coverage   58.83%   58.85%   +0.02%     
==========================================
  Files          62       62              
  Lines        3741     3753      +12     
==========================================
+ Hits         2201     2209       +8     
- Misses       1413     1416       +3     
- Partials      127      128       +1     
Impacted Files Coverage Δ
pkg/driver/camera/camera_linux.go 31.10% <66.66%> (+2.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@edaniels edaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit

pkg/driver/camera/camera_linux.go Outdated Show resolved Hide resolved
Co-authored-by: Eric Daniels <eric@erdaniels.com>
@edaniels edaniels merged commit 14bfaa5 into pion:master Apr 12, 2023
@bazile-clyde bazile-clyde deleted the RSDK-2385 branch April 12, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants