Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add H265SafariPayloader #200

Open
wants to merge 4 commits into
base: h265
Choose a base branch
from
Open

Add H265SafariPayloader #200

wants to merge 4 commits into from

Conversation

erivni
Copy link

@erivni erivni commented Nov 3, 2022

Description

Added H265SafariPayloader.
based on AlexxIT/Blog#5

@kevmo314

@kevmo314
Copy link
Contributor

kevmo314 commented Nov 3, 2022

Interesting, really weird that Safari decided to create their own payload format. This has some rather odd implications for interoperability, however. Suddenly the payloader needs to know about where the stream is sent :(

Is the Safari payloader compatible with ffmpeg RTP and others? If so, maybe it would be better to adopt the Safari format as "standard"...

Change looks good to me though, thanks for figuring this out :)

@erivni
Copy link
Author

erivni commented Nov 6, 2022

yes, we don't know why safari decided to use their own payload format.
vlc, ffplay and gst doesn't support this format, so i believe the standard should remain as is.

i changed the code to use 'copy' instead of 'append' for memory efficiency.

@shlompy, thank you as well!

@stv0g stv0g changed the title added H265SafariPayloader Add H265SafariPayloader Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants