Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pessimistic String calls for low level logs #392

Merged
merged 1 commit into from
Apr 20, 2024
Merged

Conversation

paulwe
Copy link
Contributor

@paulwe paulwe commented Apr 20, 2024

No description provided.

@paulwe paulwe requested review from davidzhao and boks1971 April 20, 2024 00:29
Copy link

codecov bot commented Apr 20, 2024

Codecov Report

Attention: Patch coverage is 79.16667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 68.15%. Comparing base (cf40c33) to head (71ef030).

Files Patch % Lines
client.go 40.00% 3 Missing ⚠️
internal/allocation/allocation.go 80.00% 1 Missing ⚠️
internal/server/turn.go 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #392      +/-   ##
==========================================
- Coverage   68.24%   68.15%   -0.10%     
==========================================
  Files          43       43              
  Lines        2337     2333       -4     
==========================================
- Hits         1595     1590       -5     
  Misses        576      576              
- Partials      166      167       +1     
Flag Coverage Δ
go 68.15% <79.16%> (-0.10%) ⬇️
wasm 27.64% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulwe paulwe merged commit 8958518 into master Apr 20, 2024
23 of 26 checks passed
@paulwe paulwe deleted the log-pessimism branch April 20, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants