Fix bad placeholders in translated strings #5852
Conversation
impaktor
force-pushed
the
fix-translated-strings
branch
2 times, most recently
from
0ae2669 to
410e4bd
Compare
|
I went through the diff and noticed many (of the few) strings that the automated script got wrong were of the type: one of the place holders misspelled, but placeholders used in different order. I've fixed those, and updated this PR
|
impaktor
force-pushed
the
fix-translated-strings
branch
from
410e4bd to
9d6d64b
Compare
data/lang/core/es.json
Outdated
| @@ -1105,7 +1105,7 @@ | |||
| }, | |||
| "OVER_N_BILLION": { | |||
| "description": "", | |||
| "message": "Alrededor de %{population}000 millones" | |||
| "message": "Alrededor de %%population000 millones" | |||
There was a problem hiding this comment.
This will need to be manually fixed.
There was a problem hiding this comment.
Yeah, I spotted that one, and I initially assumed the script was doing something wonky, but it is actually doing what it is supposed to:
2024-07-03 14:19:40.474 | DEBUG | __main__:compare_file:127 - translated: OVER_N_BILLION, ['{population}']
2024-07-03 14:19:40.474 | DEBUG | __main__:compare_file:128 - correct: OVER_N_BILLION, ['%population']
2024-07-03 14:19:40.474 | DEBUG | __main__:fix_single_typo:96 - guess: %population, wrong: {population}
2024-07-03 14:19:40.474 | DEBUG | __main__:fix_single_typo:98 - suggested: ['%population']
2024-07-03 14:19:40.501 | INFO | __main__:fix_file:215 - old: Alrededor de %{population}000 millones
2024-07-03 14:19:40.501 | INFO | __main__:fix_file:217 - new: Alrededor de %%population000 millones
My plan is to just open an issue on the strings that are "beyond broken" in transifex, and hope translator fixes it.
data/lang/core/hu.json
Outdated
| @@ -1021,7 +1021,7 @@ | |||
| }, | |||
| "NUMBER_HOURS": { | |||
| "description": "", | |||
| "message": "%hours{f.2} óra" | |||
| "message": "%hours{f.1} óra" | |||
There was a problem hiding this comment.
This is technically a valid change in format specifier.
impaktor
force-pushed
the
fix-translated-strings
branch
from
9d6d64b to
95a8aa4
Compare
This mostly fixes pioneerspacesim#5849 (translators getting the placeholders in strings wrong), BUT: - I assume we don't want to merge this PR, but push branch to transifex - As mentioned in the issue above, this only solves for strings where number of placeholders in translated and original strings are the same / unambiguous)
impaktor
force-pushed
the
fix-translated-strings
branch
from
95a8aa4 to
14ad8c1
Compare
|
I've pushed these strings to transifex now, and I believe this PR should also be merged, before next time the bot runs. |
This mostly fixes #5849 (translators getting the placeholders in strings wrong), BUT:
%and it getting close to my bed time (I'll fix tomorrow), that will add < 10 more files with correctionsPlease have a scroll of the diff. (Ping @zonkmachine, @JeromeChignoli