Fix custom systems with zero stars #5858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If a system in a sector has zero stars, the sector map would previously crash attempting to display it. - Fall back to displaying it as though it contained an M-class star, as empty star systems are a degenerate case.
- If a system is empty or contains objects with no luminance, an extremely bright object was generated. - Special-case zero-luminance to avoid graphical issues.
- Only encountered when creating a new system in the system editor, but lead to hilariously out-of-place stars in the map.
…ly-created systems - The star list was loaded correctly for systems copied from existing systems - Creating a new system would not populate the list of stars, leading to failures in code which depended on StarSystem::GetStarType()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #5857 - the primary issue was that
StarSystem::m_starswasn't being properly populated when creating a new system and adding stars to that system. As a consequence, the game thought there were no stars within the generated system and that exposed a host of bugs related to rendering and processing a system without stars.I've fixed most of the bugs related to a lack of stars which I found, but didn't perform an exhaustive search to see if there were any I missed in other parts of the game or UI.
I've also fixed a problem which lead to hilariously out-of-range values being set for a system's position within its sector when creating a new system "from scratch". As usual, just another variable which didn't get initialized properly.