magento#10045 Sitemap add item refactoring - fix coding standards

piotrkwiecinski · Jul 19, 2017 · d990c95 · d990c95
1 parent becd97c
commit d990c95
Show file tree

Hide file tree

Showing 10 changed files with 19 additions and 18 deletions.
diff --git a/app/code/Magento/Sitemap/Model/CategorySitemapItemResolver.php b/app/code/Magento/Sitemap/Model/CategorySitemapItemResolver.php
@@ -64,7 +64,7 @@ public function __construct(
     public function getItems($storeId)
     {
         $collection = $this->categoryFactory->create()->getCollection($storeId);
-        $items = array_map(function($item) use ($storeId) {
+        $items = array_map(function ($item) use ($storeId) {
             return $this->itemFactory->create([
                 'url' => $item->getUrl(),
                 'updatedAt' => $item->getUpdatedAt(),
@@ -106,4 +106,4 @@ private function getCategoryChangeFrequency($storeId)
             $storeId
         );
     }
-}
+}
diff --git a/app/code/Magento/Sitemap/Model/CmsPageSitemapItemResolver.php b/app/code/Magento/Sitemap/Model/CmsPageSitemapItemResolver.php
@@ -65,7 +65,7 @@ public function __construct(
     public function getItems($storeId)
     {
         $collection = $this->cmsPageFactory->create()->getCollection($storeId);
-        $items = array_map(function($item) use ($storeId) {
+        $items = array_map(function ($item) use ($storeId) {
             return $this->itemFactory->create([
                 'url' => $item->getUrl(),
                 'updatedAt' => $item->getUpdatedAt(),
@@ -107,4 +107,4 @@ private function getPageChangeFrequency($storeId)
             $storeId
         );
     }
-}
+}
diff --git a/app/code/Magento/Sitemap/Model/CompositeSitemapItemResolver.php b/app/code/Magento/Sitemap/Model/CompositeSitemapItemResolver.php
@@ -41,4 +41,4 @@ public function getItems($storeId)
 
         return $items;
     }
-}
+}
diff --git a/app/code/Magento/Sitemap/Model/ProductSitemapItemResolver.php b/app/code/Magento/Sitemap/Model/ProductSitemapItemResolver.php
@@ -63,7 +63,7 @@ public function __construct(
     public function getItems($storeId)
     {
         $collection = $this->productFactory->create()->getCollection($storeId);
-        $items = array_map(function($item) use ($storeId) {
+        $items = array_map(function ($item) use ($storeId) {
             return $this->itemFactory->create([
                 'url' => $item->getUrl(),
                 'updatedAt' => $item->getUpdatedAt(),
@@ -105,4 +105,4 @@ private function getProductChangeFrequency($storeId)
             $storeId
         );
     }
-}
+}
diff --git a/app/code/Magento/Sitemap/Model/SitemapItem.php b/app/code/Magento/Sitemap/Model/SitemapItem.php
@@ -90,4 +90,4 @@ public function getUpdatedAt()
     {
         return $this->updatedAt;
     }
-}
+}
diff --git a/app/code/Magento/Sitemap/Model/SitemapItemInterface.php b/app/code/Magento/Sitemap/Model/SitemapItemInterface.php
@@ -11,7 +11,8 @@
  *
  * @api
  */
-interface SitemapItemInterface {
+interface SitemapItemInterface
+{
 
     /**
      * Get url
@@ -47,4 +48,4 @@ public function getImages();
      * @return string|null
      */
     public function getUpdatedAt();
-}
+}
diff --git a/app/code/Magento/Sitemap/Model/SitemapItemResolverInterface.php b/app/code/Magento/Sitemap/Model/SitemapItemResolverInterface.php
@@ -19,4 +19,4 @@ interface SitemapItemResolverInterface
      * @return SitemapItemInterface[]
      */
     public function getItems($storeId);
-}
+}
diff --git a/app/code/Magento/Sitemap/Test/Unit/Model/CategorySitemapItemResolverTest.php b/app/code/Magento/Sitemap/Test/Unit/Model/CategorySitemapItemResolverTest.php
@@ -149,4 +149,4 @@ private function getCategoryCollectionMock($returnValue)
 
         return $sitemapCmsPageMock;
     }
-}
+}
diff --git a/app/code/Magento/Sitemap/Test/Unit/Model/CmsPageSitemapItemResolverTest.php b/app/code/Magento/Sitemap/Test/Unit/Model/CmsPageSitemapItemResolverTest.php
@@ -51,7 +51,7 @@ public function testGetItems(array $pages = [])
         $resolver = new CmsPageSitemapItemResolver($storeConfigMock, $cmsPageFactoryMock, $itemFactoryMock);
         $items = $resolver->getItems(1);
         self::assertTrue(count($items) == count($pages));
-        foreach($pages as $index => $page) {;
+        foreach ($pages as $index => $page) {
             self::assertSame($page->getUpdatedAt(), $items[$index]->getUpdatedAt());
             self::assertSame('daily', $items[$index]->getChangeFrequency());
             self::assertSame('1.0', $items[$index]->getPriority());

diff --git a/app/code/Magento/Sitemap/Test/Unit/Model/CompositeSitemapItemResolverTest.php b/app/code/Magento/Sitemap/Test/Unit/Model/CompositeSitemapItemResolverTest.php
@@ -26,7 +26,7 @@ public function testGetItems($itemResolverData, $expectedItems)
     {
         $mockResolvers = [];
 
-        foreach($itemResolverData as $data) {
+        foreach ($itemResolverData as $data) {
             $mockResolver = $this->getMockForAbstractClass(SitemapItemResolverInterface::class);
             $mockResolver->expects(self::once())
                 ->method('getItems')
@@ -48,12 +48,12 @@ public function sitemapItemsProvider()
     {
         $testCases = [];
 
-        for($i = 1; $i < 5; $i++) {
+        for ($i = 1; $i < 5; $i++) {
             $itemProviders = [];
             $expectedItems = [];
-            for($i = 1; $i < $maxProviders = random_int(1, 5); $i++) {
+            for ($i = 1; $i < $maxProviders = random_int(1, 5); $i++) {
                 $items = [];
-                for($i = 1; $i < $maxItems = random_int(2, 5); $i++) {
+                for ($i = 1; $i < $maxItems = random_int(2, 5); $i++) {
                     $sitemapItem = $this->getMockForAbstractClass(SitemapItemInterface::class);
                     $items[] = $sitemapItem;
                     $expectedItems[]  = $sitemapItem;
@@ -66,4 +66,4 @@ public function sitemapItemsProvider()
 
         return $testCases;
     }
-}
+}